New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WinUI] Fixes window blinking when resizing #18155
Conversation
This bug was introduced by #17069, but the underlying cause is a bug on WinUI that makes the window blink when setting `NavigationView.IsPaneVisible = false` (https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/47131770). After testing the samples attached on the issues the original commit fixed, this change does not seem to re-introduce those issues. Fixes #17724
/backport to release/8.0.1xx-rc2.1 |
Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6593410101 |
@emaf an error occurred while backporting to release/8.0.1xx-rc2.1, please check the run log for details! Error: @emaf is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=emaf |
/backport to release/8.0.1xx-rc2.1 |
Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6593578878 |
@samhouts an error occurred while backporting to release/8.0.1xx-rc2.1, please check the run log for details! Error: @samhouts is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=samhouts |
😭 apparently not |
/backport to release/8.0.1xx-rc2.1 |
Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6593588270 |
haha! what now, bot?? 💪 |
Description of Change
This bug was introduced by #17069, but the underlying cause is a bug on WinUI that makes the window blink when setting
NavigationView.IsPaneVisible = false
(https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/47131770).After testing the samples attached on the issues the original commit fixed, this change does not seem to re-introduce those issues.
Issues Fixed
Fixes #17724